+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39499/32250

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] Phase-2, include missing collections in outputs #39401
  • File L1Trigger/Phase2L1Taus/plugins/HPSPFTauProducer.cc modified in PR(s): [Draft] Update HGCAL pset for Phase-2 HLT menu #39450

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

• L1Trigger/Configuration (l1)
• L1Trigger/L1TTrackMatch (upgrade, l1)
• L1Trigger/Phase2L1Taus (l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04b1b3/27766/summary.html
COMMIT: df4c794
CMSSW: CMSSW_12_6_X_2022-09-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39499/27766/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3624368
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3624341
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

Thanks very much @cecilecaillol
I've only a comment of a line which already propose the change in #39401.

Thanks very much @cecilecaillol I've only a comment of a line which already propose the change in #39401.

Yes it is the same fix, I guess it is ok to have in both PRs since the change is identical

+l1

+Upgrade

This PR fixes the remaining L1 collection names L1VertexFinderEmulator ==> l1tVertexFinderEmulator. For one change which is the same as 39401, I would ask suggestion from @perrotta @rappoccio

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

+1

type bugfix

Will this PR be backported to 12_5_X ?

Hi @missirol , changes in this PR are included in this backport #39451

Ah okay, thanks @epalencia .